Merged
Conversation
ghost
added
the
Author
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
This commit adds the scenario implementations for testing the collection of Azure App Service Metadata. EnvironmentHelper is changed to IEnvironmentVariables, to introduce a test seam for environment variables, to isolate the manipulation of environment variables to tests. Update AzureAppServiceMetadataProvider to handle the additional test case.
gregkalapos
approved these changes
Mar 29, 2021
Contributor
gregkalapos
left a comment
gregkalapos
left a comment
There was a problem hiding this comment.
LGTM 👍
Added a few things below.
Co-authored-by: Gergely Kalapos <gergo@kalapos.net>
Author
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
APM agent specs automatic sync
Why
Changeset